Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Update functions #14

Merged
merged 5 commits into from
Dec 11, 2024
Merged

Chore: Update functions #14

merged 5 commits into from
Dec 11, 2024

Conversation

iLLiCiTiT
Copy link
Member

@iLLiCiTiT iLLiCiTiT commented Oct 24, 2024

Changelog Description

Revisited the client code after some time and fix/enhance cobase.

Additional info

Use new function get_launcher_storage_dir instead of get_ayon_appdirs.

Don't use code from ayon_common to download and extract files. I don't understand how it could work? ayon_common is available only in AYON launcher.

Notes

We might move some of the helper functions to calculate hash and unarchive file to ayon core.

Testing notes:

  1. Make sure to remove existing addon versions from %LOCALAPPDATA%/Ynput/AYON/addon/.
  2. Create package, upload it to server, use it in bundle.
  3. Run some publishing.

@antirotor antirotor added the type: bug Something isn't working label Dec 10, 2024
@antirotor antirotor linked an issue Dec 10, 2024 that may be closed by this pull request
1 task
@antirotor antirotor mentioned this pull request Dec 10, 2024
1 task
@antirotor
Copy link
Member

Still draft? Can we test and merge? It is currently blocking running of tests on ayon-core.

@iLLiCiTiT iLLiCiTiT marked this pull request as ready for review December 11, 2024 09:09
@iLLiCiTiT iLLiCiTiT merged commit ecb5fb7 into develop Dec 11, 2024
3 checks passed
@iLLiCiTiT iLLiCiTiT deleted the enhancement/update-functions branch December 11, 2024 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of ayon_common
3 participants